Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf: use server-http-tls to specify http security | tidb-test=pr/2248 #403

Merged
merged 3 commits into from
Nov 18, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Nov 17, 2023

What problem does this PR solve?

Issue Number: ref #402

Problem Summary: Solving problems where users want tls-client-authentication, while tiproxyctl cant prove certs for HTTP status port. It is implemented by renaming peer-tls(useless and deprecated now) to server-http-tls.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

http port now uses a separate security config server-http-tls

Signed-off-by: xhe <xw897002528@gmail.com>
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox
Copy link
Collaborator Author

xhebox commented Nov 17, 2023

/retest

1 similar comment
@xhebox
Copy link
Collaborator Author

xhebox commented Nov 17, 2023

/retest

@xhebox xhebox changed the title conf: use server-http-tls to specify http security conf: use server-http-tls to specify http security | tidb-test=pr/2248 Nov 17, 2023
@xhebox
Copy link
Collaborator Author

xhebox commented Nov 17, 2023

/retest

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 18, 2023
Copy link

ti-chi-bot bot commented Nov 18, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-18 07:31:39.857963222 +0000 UTC m=+43928.523189403: ☑️ agreed by djshow832.

Copy link

ti-chi-bot bot commented Nov 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8712ca0 into pingcap:main Nov 18, 2023
9 checks passed
@xhebox xhebox deleted the f branch November 19, 2023 04:08
djshow832 pushed a commit to djshow832/TiProxy that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants