Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix docker file for new arg #372

Merged
merged 1 commit into from
Sep 27, 2023
Merged

*: fix docker file for new arg #372

merged 1 commit into from
Sep 27, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Sep 27, 2023

What problem does this PR solve?

Issue Number: close None

Problem Summary: Missing branch variable in docker build

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 27, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 27, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-27 06:08:18.040529818 +0000 UTC m=+427887.758872034: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit b9e7d6f into pingcap:main Sep 27, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants