Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend, net: Remind the user when TiDB sets wrong proxy-protocol #362

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #360

Problem Summary:
Users are very likely to misconfigure proxy-protocol. And they do, they are hard to find the reason according to the error message.

What is changed and how it works:

  • Remind the user when TiDB and TiProxy proxy-protocol mismatch.
  • Move zap field proxy-protocol to the place where the connection is created.
  • Refine other error messages.

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)

  • No code

  • Enable TiProxy PPV2, disable TiDB PPV2, enable TLS

  • Enable TiProxy PPV2, disable TiDB PPV2, disable TLS

  • Disable TiProxy PPV2, enable TiDB PPV2, enable TLS

  • Disable TiProxy PPV2, enable TiDB PPV2, disable TLS

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested a review from bb7133 September 7, 2023 07:53
@ti-chi-bot ti-chi-bot bot added the size/M label Sep 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-07 13:09:24.216659863 +0000 UTC m=+2623728.765675845: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 7, 2023
@ti-chi-bot ti-chi-bot bot merged commit eb5b4b9 into pingcap:main Sep 7, 2023
9 checks passed
@djshow832 djshow832 deleted the pp_msg branch September 8, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remind the user when TiDB sets wrong proxy-protocol
2 participants