Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link in readme #342

Merged
merged 4 commits into from
Aug 23, 2023
Merged

fix link in readme #342

merged 4 commits into from
Aug 23, 2023

Conversation

shawn0915
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works:

fix link in readme, and remove $ so that everyone can copy/use command directly.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 August 23, 2023 01:55
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

Welcome @shawn0915! It looks like this is your first PR to pingcap/TiProxy 🎉

@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

Hi @shawn0915. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot removed the lgtm label Aug 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 23, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 23, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-23 04:11:01.944127675 +0000 UTC m=+1295426.493143663: ☑️ agreed by xhebox.
  • 2023-08-23 04:11:26.39165355 +0000 UTC m=+1295450.940669537: ✖️🔁 reset by xhebox.
  • 2023-08-23 04:12:06.455114496 +0000 UTC m=+1295491.004130503: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 44234f6 into pingcap:main Aug 23, 2023
6 checks passed
@shawn0915 shawn0915 deleted the pr-shawnyan-0823 branch November 16, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants