Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend: ignore parsing attrs error during handshake #284

Merged
merged 3 commits into from
May 19, 2023

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented May 19, 2023

What problem does this PR solve?

Issue Number: close #283

Problem Summary:
TiProxy encounters an error during parsing attributes and it panicked.

What is changed and how it works:

  • Add a Warning type and a user error msg
  • Ignore the error during parsing attrs

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox May 19, 2023 05:15
@djshow832 djshow832 merged commit 2f5bfd8 into pingcap:main May 19, 2023
@djshow832 djshow832 deleted the ignore_attrs branch May 19, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing attributes failed and causes panic
2 participants