Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: fix script on some older docker builder #269

Merged
merged 1 commit into from
Apr 13, 2023
Merged

docker: fix script on some older docker builder #269

merged 1 commit into from
Apr 13, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Apr 13, 2023

What problem does this PR solve?

Issue Number: close None

Problem Summary: It does not build on old docker.

What is changed and how it works: Directory needs to end with a /.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox
docker: fix script on some older docker builder
bad6e9a 
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 April 13, 2023 05:03
@djshow832 djshow832 merged commit ec35e64 into pingcap:main Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djshow832 djshow832 djshow832 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xhebox @djshow832