Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy: move proxyprotocol as a seperate package #247

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Mar 13, 2023

What problem does this PR solve?

Issue Number: ref #245

Problem Summary: Need to support proxy protocol for HTTP, too. Another point is that, epoll refactor will need a much simpler PacketIO and backend structure. So we seperate the package.

What is changed and how it works:

  1. move testPipe, testTCP into pkg/testkit
  2. seperate proxy protocol
  3. add var _ proxyprotocol.AddressWrapper = &originAddr{}

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@xhebox xhebox requested a review from djshow832 March 13, 2023 04:14
Signed-off-by: xhe <xw897002528@gmail.com>
@djshow832 djshow832 merged commit a688abf into pingcap:main Mar 13, 2023
@xhebox xhebox deleted the ss branch March 13, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants