Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: graceful shutdown notice in HTTP #246

Merged
merged 3 commits into from
Mar 10, 2023
Merged

server: graceful shutdown notice in HTTP #246

merged 3 commits into from
Mar 10, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Mar 9, 2023

What problem does this PR solve?

Issue Number: ref #245

Problem Summary: Return 504 when closing. Also trying to fix post merge CI & provide cross-platform cache.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
[xhe@M1PRO tiproxy]$ ./bin/tiproxyctl health
{"config_checksum":4122079757}
[xhe@M1PRO tiproxy]$ ./bin/tiproxyctl health
502 Bad Gateway: {"config_checksum":4122079757}
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Return 504 when closing server.

Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 March 9, 2023 09:38
pkg/proxy/proxy.go Outdated Show resolved Hide resolved
Signed-off-by: xhe <xw897002528@gmail.com>
@xhebox xhebox requested a review from djshow832 March 10, 2023 03:41
@djshow832 djshow832 merged commit c369737 into pingcap:main Mar 10, 2023
xhebox added a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants