proxy: extract tcp logic out further #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduce logic need in `*testSuite` and `TestXXX` Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
reviewed
Aug 3, 2022
Comment on lines
+94
to
+96
| if cerr != nil { | ||
| require.NoError(t, tc.clientIO.Close()) | ||
| } |
There was a problem hiding this comment.
It should be closed even if cerr==nil. Why not close them all at last?
There was a problem hiding this comment.
Because you may want to call tc.run() again to combine multiple methods into one test. For example, handshakeFirstTime and handshakeSecondTime.
Signed-off-by: xhe <xw897002528@gmail.com>
djshow832
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #23
Problem Summary: An effort to make tests cleaner.
What is changed and how it works:
Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.