Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: add quit source to ConnContext #236

Merged
merged 6 commits into from
Mar 6, 2023
Merged

backend: add quit source to ConnContext #236

merged 6 commits into from
Mar 6, 2023

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Mar 6, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #235

Problem Summary:
Gateway needs to know whether the client is disconnected normally or not.

What is changed and how it works:
Add QuitSource() to ConnContext. There are multiple sources.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

xhebox
xhebox reviewed Mar 6, 2023
View reviewed changes
pkg/proxy/backend/handshake_handler.go Outdated Show resolved Hide resolved
pkg/proxy/backend/backend_conn_mgr.go Outdated Show resolved Hide resolved
@djshow832 djshow832 merged commit 14429a3 into pingcap:main Mar 6, 2023
@djshow832 djshow832 deleted the err_src branch March 6, 2023 07:59
xhebox pushed a commit to xhebox/TiProxy that referenced this pull request Mar 13, 2023
@djshow832 @xhebox
backend: add quit source to ConnContext (pingcap#236)
c387466
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add quit info into the ConnContext
2 participants
@djshow832 @xhebox