router, backend: retry connecting to different backends #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhebox
approved these changes
Jan 5, 2023
| @@ -160,7 +161,7 @@ func (auth *Authenticator) handshakeFirstTime(logger *zap.Logger, clientIO *pnet | |||
| auth.attrs = resp.Attrs | |||
|
|
|||
| // In case of testing, backendIO is passed manually that we don't want to bother with the routing logic. | |||
| backendIO, err := getBackendIO(auth, auth, resp) | |||
| backendIO, err := getBackendIO(auth, auth, resp, 5*time.Second) | |||
There was a problem hiding this comment.
There is a constant, DialTimeout in backend_conn.go.
There was a problem hiding this comment.
It's different. The one passed to getBackendIO is the total timeout for all retries.
BTW, DialTimeout is also 5 seconds. Maybe it should be less?
There was a problem hiding this comment.
I think both.I think that DialTimeout should be less, but backoff duration should be larger, e.g. three or four times of DialTimeout.
xhebox
pushed a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 7, 2023
xhebox
pushed a commit
to xhebox/TiProxy
that referenced
this pull request
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #168
Problem Summary:
To adapt to the serverless tier, retry connecting to different backends one by one.
Note that this PR has not adapted to the dedicated tier yet.
What is changed and how it works:
Router.Route()returnsBackendSelectornow, which returns a backend each time for callingNext().BackendConnMgrtries connecting to the backends at max 5 seconds.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.