Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xhe xw897002528@gmail.com
What problem does this PR solve?
Issue Number: close None
Problem Summary: There are two problems.
p.wrap
is an error intended to wrap other errors, it should be appended to the error list ofpnet.Conn.Close()
.errors.Wrap
handles nil.This fixes
[1.667360865291243e+09] [error] [main.proxy] [close connection fails] [connID=0] [remoteAddr="[::1]:51379"] [error="failed to close client connection:\n\tfailed to close the connection:\n\tthis is an error from client"]
.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.