Skip to content

Conversation

@YangKeao
Copy link
Member

@YangKeao YangKeao commented Dec 2, 2025

What problem does this PR solve?

Issue Number: close #1008, close #1009

Problem Summary:

What is changed and how it works:

  1. Add a new argument filter-command-with-retry to filter out the commands according to the RETRY field. When it's enabled, the default deduplicator will not be used.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@ti-chi-bot ti-chi-bot bot requested review from bb7133 and djshow832 December 2, 2025 11:33
@ti-chi-bot ti-chi-bot bot added the size/L label Dec 2, 2025
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 39.47368% with 23 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@ad31059). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/replayer/main.go 0.00% 20 Missing ⚠️
pkg/sqlreplay/replay/replay.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage        ?   67.80%           
=======================================
  Files           ?      140           
  Lines           ?    14312           
  Branches        ?        0           
=======================================
  Hits            ?     9704           
  Misses          ?     3926           
  Partials        ?      682           
Flag Coverage Δ
unit 67.80% <39.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 3, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djshow832

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-12-03 02:48:30.76647587 +0000 UTC m=+404455.580253432: ☑️ agreed by djshow832.

@ti-chi-bot ti-chi-bot bot added the approved label Dec 3, 2025
@ti-chi-bot ti-chi-bot bot merged commit d9ef65a into pingcap:main Dec 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestDynamicInput is not stable Filter retried audit logs by the RETRY field

3 participants