Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: support remove and add partitioning #9670

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Sep 4, 2023

What problem does this PR solve?

Issue Number: close #9641

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Added support for ALTER TABLE t REMOVE PARTITIONING and ALTER TABLE t PARTITION BY ...

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2023
@mjonss
Copy link
Contributor Author

mjonss commented Sep 16, 2023

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Sep 17, 2023

/run-all-tests

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 21, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 21, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 21, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-20 08:52:59.682192235 +0000 UTC m=+680345.649780270: ☑️ agreed by asddongmen.
  • 2023-09-21 03:29:38.615226361 +0000 UTC m=+747344.582814402: ☑️ agreed by CharlesCheung96.

@mjonss
Copy link
Contributor Author

mjonss commented Sep 21, 2023

/retest

3 similar comments
@mjonss
Copy link
Contributor Author

mjonss commented Sep 21, 2023

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Sep 21, 2023

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Sep 22, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit fa13ca0 into pingcap:master Sep 22, 2023
13 checks passed
@mjonss mjonss deleted the cdc-remove-and-add-partitioning branch September 23, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Add and Remove partitioning
3 participants