sink(ticdc): fix data loss #9618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-triage-completed
release-note
ti-chi-bot
bot
added
size/S
ti-chi-bot
bot
added
size/M
hicqu
approved these changes
Aug 21, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
nongfushanquan
approved these changes
Aug 21, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hicqu, nongfushanquan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This was referenced Aug 22, 2023
|
/retest |
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Aug 22, 2023
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
3AceShowHand
pushed a commit
to 3AceShowHand/tiflow
that referenced
this pull request
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9592
What is changed and how it works?
Before this pr, asyncCloseAndClearTableSink always returns true, no matter whether the underlying table sink successfully closed. During two-phase scheduling, this error can cause the new node's table sink to write data downstream before the old node's table sink actually exits. And this problem is more likely to be repeated in batch write scenarios (such as storage sink).
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note