Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay(dm): refactor handleFileHoleExist for relay writer #9562

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

zhangjinpeng87
Copy link
Contributor

@zhangjinpeng87 zhangjinpeng87 commented Aug 14, 2023

What problem does this PR solve?

Issue Number: close #9563

What is changed and how it works?

  • Refactor handleFileHoleExist, make it only focus on handling File Hole.
  • Add a private detectDuplicateEvent function to detect duplicate event

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 14, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign overvenus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-bot
Copy link

sre-bot commented Aug 14, 2023

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed do-not-merge/needs-linked-issue labels Aug 14, 2023
@lance6716 lance6716 changed the title [DM] refactor handleFileHoleExist for relay writer relay(dm): refactor handleFileHoleExist for relay writer Aug 14, 2023
dm/relay/relay_writer.go Outdated Show resolved Hide resolved
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2023

@zhangjinpeng1987: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
jenkins-ticdc/verify 42fe808 link true /test verify
pull-dm-integration-test 42fe808 link true /test dm-integration-test
pull-engine-integration-test 42fe808 link true /test engine-integration-test
pull-dm-compatibility-test 42fe808 link true /test dm-compatibility-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DM relay_writer] handleFileHoleExist's implementation is more than what the function name tells
3 participants