-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relay(dm): refactor handleFileHoleExist
for relay writer
#9562
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
handleFileHoleExist
for relay writerhandleFileHoleExist
for relay writer
Co-authored-by: lance6716 <lance6716@gmail.com>
@zhangjinpeng1987: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #9563
What is changed and how it works?
handleFileHoleExist
, make it only focus on handling File Hole.detectDuplicateEvent
function to detect duplicate eventCheck List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note