Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gc (ticdc): optimize the algorithm calculating gc safepoint (#8464) #9014

Merged
merged 9 commits into from
Jun 1, 2023
Merged

gc (ticdc): optimize the algorithm calculating gc safepoint (#8464) #9014

merged 9 commits into from
Jun 1, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8464

What problem does this PR solve?

Issue Number: close #8403

What is changed and how it works?

gc (ticdc): Instead of keeping restarting error changefeed in 24 hours, put the error changefeed into failed state and calculate the ticdc global gc safepoint based on checkpoint ts of all changefeeds and give users 24 hours grace period to handle the failed changefeed.

e.g.,

Have two ChangeFeeds,
cf1(failed) with checkpointTs ts1
cf2(normal) with checkpointTs ts2

the global gc safepoint will be:
min(ts2, max(ts1, currentPDTs - 24 hours))

After this pr being merged:

  • Following errors will be set to fail directly:
ErrExpressionColumnNotFound,
ErrExpressionParseFailed,
ErrSchemaSnapshotNotFound,
ErrSyncRenameTableFailed,
ErrChangefeedUnretryable,
ErrGCTTLExceeded, 
ErrSnapshotLostByGC,
ErrStartTsBeforeGC,
  • all other errors will be retried no more than 90 mins
  • when cal the gcsafepoint, changefeed has been failed for more than 24 hours will be ignored

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

No

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

- only retry error changefeed for no more than 90 mins
- cleanup data of changefeed that has been failed for more than 24 hours

@ti-chi-bot ti-chi-bot mentioned this pull request May 22, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 22, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2023
@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 22, 2023
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label May 22, 2023
@ti-chi-bot ti-chi-bot added the type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. label May 22, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2023
@nongfushanquan nongfushanquan removed their assignment May 22, 2023
@charleszheng44
Copy link
Contributor

/assign

@charleszheng44
Copy link
Contributor

/retest-required

@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 23, 2023
@charleszheng44
Copy link
Contributor

/cherry-pick-invite @charleszheng44

@charleszheng44
Copy link
Contributor

/cherry-pick-invite

1 similar comment
@charleszheng44
Copy link
Contributor

/cherry-pick-invite

@ti-chi-bot
Copy link
Member Author

@charleszheng44 Please accept the invitation then you can push to the cherry-pick pull requests.
Comment with "/cherry-pick-invite" if the invitation is expired.
https://github.com/ti-chi-bot/tiflow/invitations

@charleszheng44 charleszheng44 force-pushed the cherry-pick-8464-to-release-6.5 branch from f6815bd to 04a1c00 Compare May 23, 2023 02:55
@charleszheng44
Copy link
Contributor

/test all

@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 04a1c00

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 23, 2023
@charleszheng44
Copy link
Contributor

/test all

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 23, 2023

@charleszheng44: No presubmit jobs available for pingcap/tiflow@release-6.5

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@charleszheng44
Copy link
Contributor

/run-all-tests

@nongfushanquan
Copy link
Contributor

/retest

@nongfushanquan
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot removed the status/can-merge Indicates a PR has been approved by a committer. label May 30, 2023
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 31, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 6e6f133

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 31, 2023
@nongfushanquan
Copy link
Contributor

/retest

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 31, 2023

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen
Copy link
Contributor

/run-kafka-integration-test

asddongmen
asddongmen reviewed May 31, 2023
View reviewed changes
tests/integration_tests/multi_tables_ddl_v2/run.sh Outdated
@@ -0,0 +1,84 @@
#!/bin/bash

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file mistakenly added?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed status/can-merge Indicates a PR has been approved by a committer. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 31, 2023
@charleszheng44
Copy link
Contributor

/test verify

@charleszheng44
Copy link
Contributor

/retest

@charleszheng44
Copy link
Contributor

/run-kafka-integration-test

@charleszheng44
Copy link
Contributor

/run-integration-test

@charleszheng44
Copy link
Contributor

/run-dm-integration-test

@charleszheng44
Copy link
Contributor

/run-dm-compatibility-test

@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 1, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 72b0170

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 1, 2023
@ti-chi-bot ti-chi-bot bot merged commit be85fcc into pingcap:release-6.5 Jun 1, 2023
@ti-chi-bot ti-chi-bot added cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleszheng44 charleszheng44 charleszheng44 left review comments

@asddongmen asddongmen asddongmen left review comments

Assignees

@charleszheng44 charleszheng44

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @charleszheng44 @asddongmen @nongfushanquan @CharlesCheung96 @VelocityLight