Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p(ticdc): add keep alive configuration for p2p server (#8908) #8939

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8908

What problem does this PR solve?

Issue Number: close #8907

What is changed and how it works?

if a ticdc server is hang (kill -19), the owner can not send a heartbeat message to the processor, which will cause the changefeed has a 2hours LAG(the default grpc keep alive time)
this pr adds keep alive configuration for p2p server

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 10, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. labels May 10, 2023
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels May 10, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels May 29, 2023
@sdojjy
Copy link
Member

sdojjy commented Jun 15, 2023

/merge

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 15, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-15 13:46:10.908711307 +0000 UTC m=+266167.323315386: ☑️ agreed by sdojjy.
  • 2023-06-15 16:07:28.830447429 +0000 UTC m=+274645.245051515: ☑️ agreed by 3AceShowHand.

@sdojjy
Copy link
Member

sdojjy commented Jun 19, 2023

/retest-required

1 similar comment
@sdojjy
Copy link
Member

sdojjy commented Jun 19, 2023

/retest-required

@GMHDBJD
Copy link
Contributor

GMHDBJD commented Jun 19, 2023

/retest

@ti-chi-bot ti-chi-bot bot merged commit ae3d82c into pingcap:release-6.1 Jun 19, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants