sink: support maxwell data format #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…nto feture_maxwell
…nto feture_maxwell
…nto feture_maxwell
…nto feture_maxwell
|
/run-all-tests |
zier-one
added
status/ptal
zier-one
reviewed
Sep 1, 2020
| io "io" | ||
| math "math" | ||
| math_bits "math/bits" | ||
|
|
||
| proto "github.com/golang/protobuf/proto" |
There was a problem hiding this comment.
sorry ,I don't know what's you mean,this pr has nothing to do with proto package.
There was a problem hiding this comment.
I mean, undo the changes to this file.
amyangfei
reviewed
Sep 1, 2020
cdc/sink/codec/maxwell.go
Outdated
| Ts: e.CommitTs, | ||
| Database: e.Table.Schema, | ||
| Table: e.Table.Table, | ||
| Type: "update", |
There was a problem hiding this comment.
Suggested change
| Type: "update", |
cdc/sink/codec/maxwell.go
Outdated
| return "table-alter" | ||
| } | ||
| switch ddlType { | ||
| case 3: |
There was a problem hiding this comment.
Is it better to use constant variable from parser lib instead of the const number, such as model2.ActionCreateTable?
cdc/sink/codec/maxwell.go
Outdated
| func columnToMaxwellType(columnType byte) (string, error) { | ||
| switch columnType { | ||
| // tinyint,smallint,mediumint,int | ||
| case 1, 2, 3, 9: |
There was a problem hiding this comment.
ditto, is it better to use mysql.TypeTiny
|
/run-all-tests |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Sep 3, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #869 +/- ##
===========================================
Coverage 33.2192% 33.2192%
===========================================
Files 99 99
Lines 11683 11683
===========================================
Hits 3881 3881
Misses 7416 7416
Partials 386 386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
tidb-cdcRelease note