Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo(ticdc): fix resolvedTs regression in applier's memory quota record #8620

Merged
merged 3 commits into from
Mar 22, 2023
Merged

redo(ticdc): fix resolvedTs regression in applier's memory quota record #8620

merged 3 commits into from
Mar 22, 2023

Conversation

CharlesCheung96
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #8591

What is changed and how it works?

  1. fix resolvedTs regression in applier's memory quota record

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 21, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Mar 21, 2023
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 21, 2023
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.0 Should cherry pick this PR to release-7.0 branch. and removed do-not-merge/needs-triage-completed labels Mar 21, 2023
@CharlesCheung96
Copy link
Contributor Author

/run-engine-integration-test
/run-dm-integration-test

@CharlesCheung96
Copy link
Contributor Author

test infra verified: 1659921, 1659922, 1660170

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 22, 2023
Rustin170506
Rustin170506 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any possible to add a test for it? Thanks!

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 22, 2023
@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8c53d0d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2023
@ti-chi-bot
Copy link
Member

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharlesCheung96
Copy link
Contributor Author

Any possible to add a test for it? Thanks!

It is difficult to cover this scenario with small amounts of tesging data.

@CharlesCheung96
Copy link
Contributor Author

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2023
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/run-engine-integration-test
/run-dm-integration-test

@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 721814a

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 22, 2023
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit def41a6 into pingcap:master Mar 22, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 22, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8639.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 22, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#8620
10640aa 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 22, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.0: #8640.

ti-chi-bot added a commit that referenced this pull request Mar 23, 2023
@ti-chi-bot
redo(ticdc): fix resolvedTs regression in applier's memory quota reco…
4fd7039 
…rd (#8620) (#8640)

close #8591
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this pull request Apr 3, 2023
@CharlesCheung96 @3AceShowHand
redo(ticdc): fix resolvedTs regression in applier's memory quota reco…
1dc3fc3 
…rd (pingcap#8620)

close pingcap#8591
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Apr 4, 2023
@CharlesCheung96
redo(ticdc): fix resolvedTs regression in applier's memory quota reco…
da64a1f 
…rd (pingcap#8620)

close pingcap#8591
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Apr 4, 2023
@CharlesCheung96
redo(ticdc): fix resolvedTs regression in applier's memory quota reco…
b6db2f3 
…rd (pingcap#8620)

close pingcap#8591
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Apr 4, 2023
@CharlesCheung96
redo(ticdc): fix resolvedTs regression in applier's memory quota reco…
4b69c62 
…rd (pingcap#8620)

close pingcap#8591
ti-chi-bot added a commit that referenced this pull request Apr 4, 2023
@ti-chi-bot
redo(ticdc): fix resolvedTs regression in applier's memory quota reco…
e9e5c2e 
…rd (#8620) (#8639)

close #8591
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@hicqu hicqu Awaiting requested review from hicqu

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.0 Should cherry pick this PR to release-7.0 branch. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data inconsistency after redo apply
4 participants
@CharlesCheung96 @ti-chi-bot @amyangfei @Rustin170506