Avro supports handle key(s) as Kafka key, and other miscellaneous improvements #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuzix
force-pushed
the
zixiong-avro-delete
branch
from
8269b05 to
c6af3da
Compare
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
===========================================
Coverage 34.9028% 34.9028%
===========================================
Files 97 97
Lines 11681 11681
===========================================
Hits 4077 4077
Misses 7195 7195
Partials 409 409 |
amyangfei
reviewed
Aug 22, 2020
cdc/sink/codec/avro.go
Outdated
Comment on lines
336
to
338
| if v, ok := col.Value.(uint64); ok { | ||
| col.Value = int64(v) | ||
| } |
There was a problem hiding this comment.
This conversion will lose precision, does Avro have no support for uint64?
There was a problem hiding this comment.
The implementation of Avro only supports sign integers, and passing unsigned types will cause panics. Avro should support unsigned integers in theory.
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
|
/run-integration-tests |
amyangfei
reviewed
Aug 26, 2020
| @@ -55,113 +55,130 @@ const ( | |||
| MultipleKeyFlag | |||
| // NullableFlag means the column is nullable | |||
| NullableFlag | |||
| // UnsignedFlag means the column stores an unsigned integer | |||
| UnsignedFlag | |||
There was a problem hiding this comment.
Don't forget to add this flag to document
zier-one
approved these changes
Aug 26, 2020
ti-srebot
approved these changes
Aug 26, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Check List
Tests
Release note