Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo(ticdc): limit memory usage in applier #8494

Merged
merged 10 commits into from
Mar 16, 2023
Merged

redo(ticdc): limit memory usage in applier #8494

merged 10 commits into from
Mar 16, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Mar 9, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8056

What is changed and how it works?

  1. Limit total memory usage in reader.
  2. Add memory quota in redo applier.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`Fix the issue that redo apply may cause OOM`.

@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 9, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • hicqu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 9, 2023
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2023
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2023
@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4f46144

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. and removed status/can-merge Indicates a PR has been approved by a committer. labels Mar 14, 2023
@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ef021c3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2023
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2023
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f953077

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 15, 2023
@CharlesCheung96
Copy link
Contributor Author

/run-integration-test

@ti-chi-bot
Copy link
Member

@CharlesCheung96: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@CharlesCheung96
Copy link
Contributor Author

/run-verify

@ti-chi-bot ti-chi-bot merged commit 7848c0c into pingcap:master Mar 16, 2023
@CharlesCheung96 CharlesCheung96 added the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Apr 4, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 4, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8739.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Apr 4, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#8494
676f0c6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Apr 4, 2023
@CharlesCheung96
redo(ticdc): limit memory usage in applier (pingcap#8494)
17caecf 
ref pingcap#8056
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Apr 4, 2023
@CharlesCheung96
redo(ticdc): limit memory usage in applier (pingcap#8494)
724e002 
ref pingcap#8056
@CharlesCheung96 CharlesCheung96 mentioned this pull request Apr 4, 2023
Merged
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Apr 4, 2023
@CharlesCheung96
redo(ticdc): limit memory usage in applier (pingcap#8494)
6619c31 
ref pingcap#8056
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Apr 4, 2023
@CharlesCheung96
redo(ticdc): limit memory usage in applier (pingcap#8494)
4c7dcff 
ref pingcap#8056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hicqu hicqu hicqu approved these changes

@Rustin170506 Rustin170506 Rustin170506 approved these changes

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharlesCheung96 @ti-chi-bot @hicqu @Rustin170506