Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink(ticdc): convert values of pre-columns properly #8421

Merged
merged 8 commits into from
Mar 6, 2023
Merged

sink(ticdc): convert values of pre-columns properly #8421

merged 8 commits into from
Mar 6, 2023

Conversation

zhaoxinyu
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #8420

What is changed and how it works?

  • Add the missing conversion step for values of per-columns in delete event.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • nongfushanquan

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2023
@zhaoxinyu
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 3, 2023
@zhaoxinyu
Copy link
Contributor Author

/run-all-tests

@zhaoxinyu
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2023
@zhaoxinyu
Copy link
Contributor Author

Some unit tests need to be added

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 6, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2023
@zhaoxinyu zhaoxinyu changed the title sink(ticdc): convert values of pre-columns in delete event properly sink(ticdc): convert values of pre-columns properly Mar 6, 2023
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Mar 6, 2023
@zhaoxinyu
Copy link
Contributor Author

/run-all-tests

1 similar comment
@nongfushanquan
Copy link
Contributor

/run-all-tests

@nongfushanquan
Copy link
Contributor

/run-kafka-integration-test

@zhaoxinyu
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2023
@zhaoxinyu
Copy link
Contributor Author

/run-all-tests

@nongfushanquan
Copy link
Contributor

/run-integration-test
/run-kafka-integration-test

@nongfushanquan
Copy link
Contributor

/run-verify

@zhaoxinyu
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9afc586

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 6, 2023
@ti-chi-bot ti-chi-bot merged commit a32372b into pingcap:master Mar 6, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8437.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 6, 2023
@zhaoxinyu @ti-chi-bot
This is an automated cherry-pick of pingcap#8421
d3c4c12 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 6, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8438.

ti-chi-bot added a commit that referenced this pull request Mar 6, 2023
@ti-chi-bot
sink(ticdc): convert values of pre-columns properly (#8421) (#8438)
63372e3 
close #8420
ti-chi-bot added a commit that referenced this pull request Mar 7, 2023
@ti-chi-bot
sink(ticdc): convert values of pre-columns properly (#8421) (#8437)
cc2a701 
close #8420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen Awaiting requested review from asddongmen

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete and update events may not be correctly sinked to downstream
4 participants
@zhaoxinyu @ti-chi-bot @nongfushanquan @CharlesCheung96