Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redo(ticdc): add unit tests for redo meta manager #8363

Merged
merged 2 commits into from
Mar 2, 2023
Merged

redo(ticdc): add unit tests for redo meta manager #8363

merged 2 commits into from
Mar 2, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Feb 23, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #8056

What is changed and how it works?

  1. add unit tests for redo meta manager, increase the coverage rate of cdc/redo from 37.5% to 81.8%.

before:

PASS
        github.com/pingcap/tiflow/cdc/redo      coverage: 37.5% of statements
ok      github.com/pingcap/tiflow/cdc/redo      7.878s  coverage: 37.5% of statements

after:

PASS
        github.com/pingcap/tiflow/cdc/redo      coverage: 81.8% of statements
ok      github.com/pingcap/tiflow/cdc/redo      8.086s  coverage: 81.8% of statements

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen
  • zhaoxinyu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 23, 2023
@CharlesCheung96
Copy link
Contributor Author

/hold wait-for-previous-pr-merge

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the add_tests_to_redo_memory_writer branch from 984564e to f06721f Compare March 2, 2023 05:25
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 2, 2023
@CharlesCheung96 CharlesCheung96 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2023
@CharlesCheung96
Copy link
Contributor Author

/run-all-tests

@CharlesCheung96 CharlesCheung96 changed the title redo(ticdc): add unit tests for redo memory writer redo(ticdc): add unit tests for redo meta manager Mar 2, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 2, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 2, 2023
@CharlesCheung96
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f06721f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 2, 2023
@ti-chi-bot ti-chi-bot merged commit 8430a08 into pingcap:master Mar 2, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 2, 2023
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8422.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Mar 2, 2023
@CharlesCheung96 @ti-chi-bot
This is an automated cherry-pick of pingcap#8363
c0c53ad 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Mar 3, 2023
@CharlesCheung96
redo(ticdc): add unit tests for redo meta manager (pingcap#8363)
625d2ba 
ref pingcap#8056
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Mar 6, 2023
@CharlesCheung96
redo(ticdc): add unit tests for redo meta manager (pingcap#8363)
0748ef9 
ref pingcap#8056
CharlesCheung96 added a commit to ti-chi-bot/tiflow that referenced this pull request Mar 21, 2023
@CharlesCheung96
redo(ticdc): add unit tests for redo meta manager (pingcap#8363)
593f253 
ref pingcap#8056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@zhaoxinyu zhaoxinyu zhaoxinyu approved these changes

@hicqu hicqu Awaiting requested review from hicqu

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CharlesCheung96 @ti-chi-bot @zhaoxinyu @asddongmen