Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner: includes stopped changefeed when calculating gc safepoint #797

Merged
merged 6 commits into from
Aug 3, 2020
Merged

owner: includes stopped changefeed when calculating gc safepoint #797

merged 6 commits into from
Aug 3, 2020

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Jul 27, 2020 •
edited
Loading

What problem does this PR solve?

Fix bug found in pingcap/ticdc#791 & pingcap/ticdc#810

What is changed and how it works?

  • Introduce a stoppedFeeds fields in owner
  • checkpoint of stopped changefeed is also taken into consideration when calculating safepoint in owner
  • clear gc safepoint if no running and stopped changefeed

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix the bug that GC safepoint will be forwarded beyond the checkpoint of stopped changefeed.

@amyangfei amyangfei added type/bugfix This PR fixes a bug. status/ptal Could you please take a look? labels Jul 27, 2020
@amyangfei amyangfei force-pushed the gc-safepoint-for-failed-feeds branch from 1948dd8 to 2466328 Compare July 27, 2020 14:38
@amyangfei
Copy link
Contributor Author

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2020 •
edited
Loading

Codecov Report

Merging #797 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #797   +/-   ##
===========================================
  Coverage   32.4428%   32.4428%           
===========================================
  Files            97         97           
  Lines         10631      10631           
===========================================
  Hits           3449       3449           
  Misses         6846       6846           
  Partials        336        336

@amyangfei
Copy link
Contributor Author

/run-all-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0

@amyangfei amyangfei added this to the v4.0.5 milestone Jul 30, 2020
@amyangfei amyangfei added the release-blocker This issue blocks a release. Please solve it ASAP. label Aug 3, 2020
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 3, 2020
@liuzix
Copy link
Contributor

liuzix commented Aug 3, 2020

/lgtm

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 3, 2020
@zier-one
Copy link
Contributor

zier-one commented Aug 3, 2020

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 815

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 3, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@amyangfei merge failed.

@amyangfei
Copy link
Contributor Author

/merged

@amyangfei
Copy link
Contributor Author

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 815

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit fb76202 into pingcap:master Aug 3, 2020
@amyangfei amyangfei deleted the gc-safepoint-for-failed-feeds branch August 3, 2020 11:32
@amyangfei amyangfei mentioned this pull request Aug 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zier-one zier-one zier-one approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
release-blocker This issue blocks a release. Please solve it ASAP. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
v4.0.5
Development

Successfully merging this pull request may close these issues.
5 participants
@amyangfei @codecov-commenter @liuzix @zier-one @ti-srebot