expression_filter(dm): fix append update filter for non-update item #7851
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
needs-cherry-pick-release-6.1
lance6716
changed the title
|
ptal @asddongmen @okJiang |
| always_false: | ||
| schema: "expr_filter" | ||
| table: "t2" | ||
| update-old-value-expr: "1 = 0" | ||
| update-new-value-expr: "1 = 0" |
There was a problem hiding this comment.
Can you explain this configuration? I did not figure out why added it.
There was a problem hiding this comment.
this is a FALSE expression, so it should not skip any UPDATE. But before we fix the issue it will skip
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 3c90190
|
ti-chi-bot
added
the
status/can-merge
|
@lance6716: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests
If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: new pull request created to branch |
Signed-off-by: lance6716 lance6716@gmail.com
What problem does this PR solve?
Issue Number: close #7831
What is changed and how it works?
I forget the case that a table has both insert and update expression filter
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note