Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning(dm): add config value to use local backend #7448

Merged
merged 11 commits into from
Nov 10, 2022
Merged

lightning(dm): add config value to use local backend #7448

merged 11 commits into from
Nov 10, 2022

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Oct 25, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #3510

What is changed and how it works?

loaders.{config-name}.import-mode can set "logical" or "physical", to use tidb or local backend of lightning respectively

Check List

Tests

  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • buchuitoudegou
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2022
@lance6716
change config value
8bfdc05 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [DNM]lightning(dm): add 'sst' config value to use local backend lightning(dm): add config value to use local backend Nov 1, 2022
@lance6716
align with spec
77d7274 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Nov 1, 2022
@lance6716
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-triage-completed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 1, 2022
@lance6716
fix some CI
78b2356 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
fix CI
1a20c07 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 1, 2022
@lance6716
fix CI
c1ae356 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
remove a test temporary
8bf75c0 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
change default value to logical
fe27f1d 
Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716
fix a data race
9155f42 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 4, 2022
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @lichunzhu

@lance6716
Copy link
Contributor Author

ptal

lichunzhu
lichunzhu reviewed Nov 7, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

dm/tests/lightning_mode/run.sh
Comment on lines -146 to -152
# test drop table if exists
run_sql_source1 "drop table if exists \`lightning_mode\`.\`tb1\`;"
run_sql_source1 "drop table if exists \`lightning_mode\`.\`tb1\`;"
run_sql_source2 "drop table if exists \`lightning_mode\`.\`tb2\`;"
run_sql_source2 "drop table if exists \`lightning_mode\`.\`tb2\`;"
check_log_not_contains $WORK_DIR/worker1/log/dm-worker.log "Error .* Table .* doesn't exist"
check_log_not_contains $WORK_DIR/worker2/log/dm-worker.log "Error .* Table .* doesn't exist"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we delete these checks?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems these tests are duplicated with all_mode, I guess the original developer copied from there. Many tests are not needed to repeat again

lichunzhu
lichunzhu approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 7, 2022
@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @buchuitoudegou

@lance6716
Copy link
Contributor Author

ptal @GMHDBJD @buchuitoudegou

@lance6716
remove unneeded line
8a3b8c4 
Signed-off-by: lance6716 <lance6716@gmail.com>
buchuitoudegou
buchuitoudegou approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@buchuitoudegou buchuitoudegou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 10, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8a3b8c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 10, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit eeaa0b4 into pingcap:master Nov 10, 2022
@lance6716 lance6716 mentioned this pull request Nov 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@buchuitoudegou buchuitoudegou buchuitoudegou approved these changes

@GMHDBJD GMHDBJD Awaiting requested review from GMHDBJD

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lance6716 @ti-chi-bot @lichunzhu @buchuitoudegou