Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*(engine): remove some deprecated code #7411

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #6849

What is changed and how it works?

  • Remove unused containers.Queue interface
  • Remove deprecated unit test in engine/test, since this test is lack of maintenance and is not quite useful.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@amyangfei amyangfei added the area/engine Issues or PRs related to Dataflow Engine. label Oct 20, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 20, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CharlesCheung96
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #7411 (7f6e8b8) into master (84ef430) will increase coverage by 0.0660%.
The diff coverage is 66.8151%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.6159% <73.5294%> (+0.1214%) ⬆️
dm 51.9591% <100.0000%> (-0.0121%) ⬇️
engine 61.0410% <31.3953%> (+0.1873%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7411        +/-   ##
================================================
+ Coverage   59.7990%   59.8650%   +0.0660%     
================================================
  Files           801        801                
  Lines         91968      91900        -68     
================================================
+ Hits          54996      55016        +20     
+ Misses        32180      32090        -90     
- Partials       4792       4794         +2     

@amyangfei
Copy link
Contributor Author

/run-engine-integration-test

@amyangfei amyangfei added the status/ptal Could you please take a look? label Oct 20, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 20, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 20, 2022
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4952187

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 20, 2022
@ti-chi-bot ti-chi-bot merged commit 6e74b7c into pingcap:master Oct 20, 2022
@amyangfei amyangfei deleted the remove-deprecated-code branch October 20, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants