Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: collect slow table latency metrics #7323

Merged
merged 11 commits into from
Oct 12, 2022
Merged

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Issue Number: ref #4757

What is changed and how it works?

Collect slow table latency metrics.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. area/ticdc Issues or PRs related to TiCDC. labels Oct 11, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 11, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 11, 2022
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 11, 2022
@overvenus overvenus changed the title Workload cdc: collect slow table latency metrics Oct 11, 2022
Signed-off-by: Neil Shen <overvenus@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #7323 (5b94b5b) into master (8f81dbb) will decrease coverage by 0.1180%.
The diff coverage is 54.7206%.

Additional details and impacted files
Flag Coverage Δ
cdc 67.0522% <55.7047%> (-0.2619%) ⬇️
dm 51.9313% <36.6666%> (-0.0228%) ⬇️
engine 61.0887% <57.1428%> (+0.0158%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #7323        +/-   ##
================================================
- Coverage   59.7265%   59.6085%   -0.1181%     
================================================
  Files           790        789         -1     
  Lines         91204      91190        -14     
================================================
- Hits          54473      54357       -116     
- Misses        31987      32052        +65     
- Partials       4744       4781        +37     

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2022
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2022
@sdojjy
Copy link
Member

sdojjy commented Oct 12, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f643876

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 12, 2022
@ti-chi-bot
Copy link
Member

@overvenus: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@overvenus
Copy link
Member Author

/run-verify

@overvenus
Copy link
Member Author

/verify

@overvenus
Copy link
Member Author

/run-verify

@ti-chi-bot ti-chi-bot merged commit c6a9dfa into pingcap:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/kv-client TiKV kv log client component. component/metrics-logging Metrics and logging component. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants