Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migration(ticdc): fix backup key issue #6232

Merged
merged 1 commit into from
Jul 8, 2022
Merged

migration(ticdc): fix backup key issue #6232

merged 1 commit into from
Jul 8, 2022

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Jul 8, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #5301

What is changed and how it works?

fix backup key issue
change from
/tidb/cdc/__backup__/0//tidb/cdc/changefeed/info/6974d70f-d798-4046-8f06-f969d4c766f1
to
/tidb/cdc/__backup__/0/tidb/cdc/changefeed/info/6974d70f-d798-4046-8f06-f969d4c766f1

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

 `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 8, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 8, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 8, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 8, 2022
@sdojjy
Copy link
Member Author

sdojjy commented Jul 8, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 88235bd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 8, 2022
@sdojjy
Copy link
Member Author

sdojjy commented Jul 8, 2022

/run-verify-test
/run-kafka-integration-test

@sdojjy
Copy link
Member Author

sdojjy commented Jul 8, 2022

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit b4259d5 into pingcap:cli-use-open-api Jul 8, 2022
@sdojjy sdojjy deleted the fix-backup-issue branch July 11, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@asddongmen asddongmen asddongmen approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdojjy @ti-chi-bot @3AceShowHand @asddongmen