tp: separate balance scheduler to basic and balance #5842

overvenus · 2022-06-13T04:57:37Z

What problem does this PR solve?

Issue Number: ref #4757

What is changed and how it works?

Separate balance scheduler to basic and balance

Check List

Tests

Unit test

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Signed-off-by: Neil Shen <overvenus@gmail.com>

ti-chi-bot · 2022-06-13T04:57:38Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

3AceShowHand

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: Neil Shen <overvenus@gmail.com>

cdc/scheduler/internal/tp/scheduler_basic.go

3AceShowHand · 2022-06-13T07:37:55Z

cdc/scheduler/internal/tp/scheduler_rebalance.go

@@ -93,8 +93,8 @@ func newBurstBalanceMoveTables(
 	}

 	for tableID, rep := range replications {


it looks that newBurstBalanceMoveTables , the parameter currentTables is not used.

Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: clean up stale capture table metrics Signed-off-by: Neil Shen <overvenus@gmail.com> * tp: refine balance scheduler Signed-off-by: Neil Shen <overvenus@gmail.com> * tp: seperate balance scheduler to basic and balance Signed-off-by: Neil Shen <overvenus@gmail.com> * fix tests Signed-off-by: Neil Shen <overvenus@gmail.com> * Apply suggestions from code review Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com> * address comments Signed-off-by: Neil Shen <overvenus@gmail.com> Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>

overvenus added 3 commits June 11, 2022 21:33

tp: clean up stale capture table metrics

821781b

Signed-off-by: Neil Shen <overvenus@gmail.com>

tp: refine balance scheduler

a30e11a

Signed-off-by: Neil Shen <overvenus@gmail.com>

tp: seperate balance scheduler to basic and balance

9b7e35a

Signed-off-by: Neil Shen <overvenus@gmail.com>

overvenus added component/scheduler TiCDC inner scheduler component. area/ticdc Issues or PRs related to TiCDC. labels Jun 13, 2022

overvenus requested a review from 3AceShowHand June 13, 2022 04:57

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 13, 2022

fix tests

fa1514a

Signed-off-by: Neil Shen <overvenus@gmail.com>

3AceShowHand reviewed Jun 13, 2022

View reviewed changes

cdc/scheduler/internal/tp/scheduler_basic.go Outdated Show resolved Hide resolved

3AceShowHand reviewed Jun 13, 2022

View reviewed changes

cdc/scheduler/internal/tp/scheduler_basic.go Outdated Show resolved Hide resolved

3AceShowHand reviewed Jun 13, 2022

View reviewed changes

overvenus and others added 2 commits June 13, 2022 16:47

Apply suggestions from code review

4b56a8e

Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>

address comments

6ff8dba

Signed-off-by: Neil Shen <overvenus@gmail.com>

3AceShowHand approved these changes Jun 13, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 13, 2022

3AceShowHand merged commit 3daf68a into pingcap:fb/latency Jun 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tp: separate balance scheduler to basic and balance #5842

tp: separate balance scheduler to basic and balance #5842

overvenus commented Jun 13, 2022

ti-chi-bot commented Jun 13, 2022 •

edited

Loading

3AceShowHand Jun 13, 2022

		@@ -93,8 +93,8 @@ func newBurstBalanceMoveTables(
		}

		for tableID, rep := range replications {

tp: separate balance scheduler to basic and balance #5842

tp: separate balance scheduler to basic and balance #5842

Conversation

overvenus commented Jun 13, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

Questions

Will it cause performance regression or break compatibility?

Do you need to update user documentation, design documentation or monitoring documentation?

Release note

ti-chi-bot commented Jun 13, 2022 • edited Loading

3AceShowHand Jun 13, 2022

Choose a reason for hiding this comment

ti-chi-bot commented Jun 13, 2022 •

edited

Loading