Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

latency(cdc): 2 phase scheduling processor bug fix #5728

Merged
merged 14 commits into from
Jun 6, 2022
Merged

latency(cdc): 2 phase scheduling processor bug fix #5728

merged 14 commits into from
Jun 6, 2022

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #4757

What is changed and how it works?

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 2, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 2, 2022
@3AceShowHand 3AceShowHand changed the base branch from master to fb/latency June 2, 2022 10:39
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 2, 2022
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 2, 2022
overvenus
overvenus reviewed Jun 6, 2022
View reviewed changes
cdc/scheduler/internal/tp/schedulepb/table_schedule.pb.go Outdated Show resolved Hide resolved
cdc/processor/processor.go Show resolved Hide resolved
cdc/processor/pipeline/sink.go Outdated Show resolved Hide resolved
@overvenus
Copy link
Member

Test TestTableExecutorAddingTableDirectly fails.

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 6, 2022
overvenus
overvenus reviewed Jun 6, 2022
View reviewed changes
cdc/scheduler/internal/tp/agent.go

revision, err := etcdClient.GetOwnerRevision(etcdCliCtx, captureID)
revision, err := etcdClient.GetOwnerRevision(etcdCliCtx, ownerCaptureID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any test covers it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, a mock etcd client is expected.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 6, 2022
@overvenus
Copy link
Member

/run-unit-test

@overvenus overvenus merged commit 0b10d98 into pingcap:fb/latency Jun 6, 2022
overvenus pushed a commit to overvenus/ticdc that referenced this pull request Jun 21, 2022
@3AceShowHand @overvenus
latency(cdc): 2 phase scheduling processor bug fix (pingcap#5728)
1a21436 
* fix by suggestion, use unique state for the table.
* fix TestTableExecutorAddingTableDirectly
* add ut TestTableExecutorAddingTableIndirectly
* add ut TestTableExecutorAddingTableIndirectly
overvenus pushed a commit to overvenus/ticdc that referenced this pull request Jun 21, 2022
@3AceShowHand @overvenus
latency(cdc): 2 phase scheduling processor bug fix (pingcap#5728)
ce9b4ec 
* fix by suggestion, use unique state for the table.
* fix TestTableExecutorAddingTableDirectly
* add ut TestTableExecutorAddingTableIndirectly
* add ut TestTableExecutorAddingTableIndirectly
overvenus pushed a commit to overvenus/ticdc that referenced this pull request Jun 23, 2022
@3AceShowHand @overvenus
latency(cdc): 2 phase scheduling processor bug fix (pingcap#5728)
cf69ee3 
* fix by suggestion, use unique state for the table.
* fix TestTableExecutorAddingTableDirectly
* add ut TestTableExecutorAddingTableIndirectly
* add ut TestTableExecutorAddingTableIndirectly
overvenus pushed a commit to overvenus/ticdc that referenced this pull request Jun 23, 2022
@3AceShowHand @overvenus
latency(cdc): 2 phase scheduling processor bug fix (pingcap#5728)
c86928a 
* fix by suggestion, use unique state for the table.
* fix TestTableExecutorAddingTableDirectly
* add ut TestTableExecutorAddingTableIndirectly
* add ut TestTableExecutorAddingTableIndirectly
overvenus pushed a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
@3AceShowHand @overvenus
latency(cdc): 2 phase scheduling processor bug fix (pingcap#5728)
120338b 
* fix by suggestion, use unique state for the table.
* fix TestTableExecutorAddingTableDirectly
* add ut TestTableExecutorAddingTableIndirectly
* add ut TestTableExecutorAddingTableIndirectly
overvenus pushed a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
@3AceShowHand @overvenus
latency(cdc): 2 phase scheduling processor bug fix (pingcap#5728)
0fbcc2e 
* fix by suggestion, use unique state for the table.
* fix TestTableExecutorAddingTableDirectly
* add ut TestTableExecutorAddingTableIndirectly
* add ut TestTableExecutorAddingTableIndirectly
overvenus pushed a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
@3AceShowHand @overvenus
latency(cdc): 2 phase scheduling processor bug fix (pingcap#5728)
178b7c3 
* fix by suggestion, use unique state for the table.
* fix TestTableExecutorAddingTableDirectly
* add ut TestTableExecutorAddingTableIndirectly
* add ut TestTableExecutorAddingTableIndirectly
overvenus pushed a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
@3AceShowHand @overvenus
latency(cdc): 2 phase scheduling processor bug fix (pingcap#5728)
de23f4f 
* fix by suggestion, use unique state for the table.
* fix TestTableExecutorAddingTableDirectly
* add ut TestTableExecutorAddingTableIndirectly
* add ut TestTableExecutorAddingTableIndirectly
ti-chi-bot pushed a commit that referenced this pull request Jun 24, 2022
@3AceShowHand @ti-chi-bot
latency(cdc): 2 phase scheduling processor bug fix (#5728)
3066772 
* fix by suggestion, use unique state for the table.
* fix TestTableExecutorAddingTableDirectly
* add ut TestTableExecutorAddingTableIndirectly
* add ut TestTableExecutorAddingTableIndirectly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@3AceShowHand @ti-chi-bot @overvenus