Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc: integrate two phase scheduler #5710

Merged
merged 10 commits into from
Jun 2, 2022

Conversation

overvenus
Copy link
Member

@overvenus overvenus commented Jun 1, 2022

What problem does this PR solve?

Issue Number: ref #4757

What is changed and how it works?

Integrate two-phase scheduler and fix two bug

  • Fix duplicate topic handlers panic
  • Add From to messages from scheduler
  • Fix missing processor epoch
  • Fix missing checkpoint ts in burstBalanceTask
  • Fix lost AddTable request during Commit

Check List

Tests

  • Unit test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@overvenus overvenus added component/scheduler TiCDC inner scheduler component. area/ticdc Issues or PRs related to TiCDC. labels Jun 1, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jun 1, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 1, 2022
@overvenus overvenus changed the title Fb/latency testing cdc: integrate two phase scheduler Jun 1, 2022
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 1, 2022
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 2, 2022
@overvenus overvenus marked this pull request as ready for review June 2, 2022 03:37
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 2, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (fb/latency@0b1c089). Click here to learn what that means.
The diff coverage is n/a.

Flag Coverage Δ
cdc 62.4713% <0.0000%> (?)
dm 52.0374% <0.0000%> (?)
engine 58.7516% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff               @@
##             fb/latency      #5710   +/-   ##
===============================================
  Coverage              ?   56.9524%           
===============================================
  Files                 ?        684           
  Lines                 ?      80425           
  Branches              ?          0           
===============================================
  Hits                  ?      45804           
  Misses                ?      30379           
  Partials              ?       4242           

Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2022
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 2, 2022
@3AceShowHand 3AceShowHand merged commit 39dc96f into pingcap:fb/latency Jun 2, 2022
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 21, 2022
* cdc: integrate two phase scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix duplicate topic handlers panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add From to messages from scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add more comments and fix typo

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix missing table ID in table meta

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix processor.tick panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing processor epoch

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing checkpoint ts in burstBalanceTask

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix lost AddTable request during Commit

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Revert "cdc: fix processor.tick panic"

This reverts commit ebb0f2c.
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 21, 2022
* cdc: integrate two phase scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix duplicate topic handlers panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add From to messages from scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add more comments and fix typo

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix missing table ID in table meta

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix processor.tick panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing processor epoch

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing checkpoint ts in burstBalanceTask

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix lost AddTable request during Commit

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Revert "cdc: fix processor.tick panic"

This reverts commit ebb0f2c.
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 23, 2022
* cdc: integrate two phase scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix duplicate topic handlers panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add From to messages from scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add more comments and fix typo

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix missing table ID in table meta

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix processor.tick panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing processor epoch

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing checkpoint ts in burstBalanceTask

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix lost AddTable request during Commit

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Revert "cdc: fix processor.tick panic"

This reverts commit ebb0f2c.
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 23, 2022
* cdc: integrate two phase scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix duplicate topic handlers panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add From to messages from scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add more comments and fix typo

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix missing table ID in table meta

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix processor.tick panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing processor epoch

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing checkpoint ts in burstBalanceTask

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix lost AddTable request during Commit

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Revert "cdc: fix processor.tick panic"

This reverts commit ebb0f2c.
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
* cdc: integrate two phase scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix duplicate topic handlers panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add From to messages from scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add more comments and fix typo

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix missing table ID in table meta

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix processor.tick panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing processor epoch

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing checkpoint ts in burstBalanceTask

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix lost AddTable request during Commit

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Revert "cdc: fix processor.tick panic"

This reverts commit ebb0f2c.
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
* cdc: integrate two phase scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix duplicate topic handlers panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add From to messages from scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add more comments and fix typo

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix missing table ID in table meta

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix processor.tick panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing processor epoch

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing checkpoint ts in burstBalanceTask

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix lost AddTable request during Commit

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Revert "cdc: fix processor.tick panic"

This reverts commit ebb0f2c.
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
* cdc: integrate two phase scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix duplicate topic handlers panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add From to messages from scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add more comments and fix typo

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix missing table ID in table meta

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix processor.tick panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing processor epoch

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing checkpoint ts in burstBalanceTask

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix lost AddTable request during Commit

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Revert "cdc: fix processor.tick panic"

This reverts commit ebb0f2c.
overvenus added a commit to overvenus/ticdc that referenced this pull request Jun 24, 2022
* cdc: integrate two phase scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix duplicate topic handlers panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add From to messages from scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add more comments and fix typo

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix missing table ID in table meta

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix processor.tick panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing processor epoch

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing checkpoint ts in burstBalanceTask

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix lost AddTable request during Commit

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Revert "cdc: fix processor.tick panic"

This reverts commit ebb0f2c.
ti-chi-bot pushed a commit that referenced this pull request Jun 24, 2022
* cdc: integrate two phase scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix duplicate topic handlers panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add From to messages from scheduler

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: add more comments and fix typo

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix missing table ID in table meta

Signed-off-by: Neil Shen <overvenus@gmail.com>

* cdc: fix processor.tick panic

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing processor epoch

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix missing checkpoint ts in burstBalanceTask

Signed-off-by: Neil Shen <overvenus@gmail.com>

* tp: fix lost AddTable request during Commit

Signed-off-by: Neil Shen <overvenus@gmail.com>

* Revert "cdc: fix processor.tick panic"

This reverts commit ebb0f2c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. component/scheduler TiCDC inner scheduler component. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants