test(dm): show full result of ps on kill fail #5667
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
the
release-note-none
ti-chi-bot
added
the
size/XS
| @@ -16,5 +16,5 @@ while [ $WAIT_COUNT -lt 120 ]; do | |||
| ((WAIT_COUNT++)) | |||
| done | |||
|
|
|||
| echo "process $process didn't exit after 120 seconds, current processlist: $(pgrep $process)" | |||
| echo "process $process didn't exit after 120 seconds, current processlist: $(ps -ef | grep $process | grep -v 'grep')" | |||
There was a problem hiding this comment.
maybe ps $process is enough.
Not sure if it's a busybox ps in CI that lacks lots of information 😂 we might keep current code
There was a problem hiding this comment.
maybe
ps $processis enough.
ps can't filter by name, has to grep
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 7e91fee
|
ti-chi-bot
added
the
status/can-merge
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #5667 +/- ##
================================================
+ Coverage 56.0768% 56.6733% +0.5964%
================================================
Files 535 676 +141
Lines 70143 79016 +8873
================================================
+ Hits 39334 44781 +5447
- Misses 27078 30039 +2961
- Partials 3731 4196 +465 |
What problem does this PR solve?
Issue Number: ref #5089
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note