Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/master(engine): fix PreDispatch failure handling #5603

Merged

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented May 26, 2022

What problem does this PR solve?

Issue Number: close #5589

What is changed and how it works?

  • Abort the dispatch appropriately if PreDispatchTask has failed.

Check List

Tests

  • Unit test
None

@liuzix liuzix added the type/enhancement The issue or PR belongs to an enhancement. label May 26, 2022
@liuzix liuzix requested a review from amyangfei May 26, 2022 04:13
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 26, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • maxshuang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2022
@liuzix liuzix added type/bugfix This PR fixes a bug. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/enhancement The issue or PR belongs to an enhancement. labels May 26, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels May 26, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 26, 2022
@liuzix
Copy link
Contributor Author

liuzix commented May 26, 2022

/run-verify

@liuzix
Copy link
Contributor Author

liuzix commented May 26, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: babbde1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2022
@liuzix
Copy link
Contributor Author

liuzix commented May 26, 2022

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2022

Codecov Report

Merging #5603 (aa33e6a) into master (fcea4d5) will increase coverage by 0.1099%.
The diff coverage is 60.3387%.

Flag Coverage Δ
cdc 61.4819% <62.0865%> (+0.3338%) ⬆️
dm 52.0354% <56.4728%> (-0.0073%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5603        +/-   ##
================================================
+ Coverage   56.0768%   56.1868%   +0.1099%     
================================================
  Files           535        528         -7     
  Lines         70143      69680       -463     
================================================
- Hits          39334      39151       -183     
+ Misses        27078      26807       -271     
+ Partials       3731       3722         -9     

@ti-chi-bot ti-chi-bot merged commit e87ea0f into pingcap:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre dispatch task failed cause a worker does not failover
5 participants