Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv(ticdc): fix data loss when upstream txn conflicts during scan (#5477) #5583

Merged
merged 2 commits into from
May 26, 2022
Merged

kv(ticdc): fix data loss when upstream txn conflicts during scan (#5477) #5583

merged 2 commits into from
May 26, 2022

Conversation

overvenus
Copy link
Member

What problem does this PR solve?

Issue Number: ref #5468

What is changed and how it works?

See #5477

Check List

Tests

  • Unit test
Fix data loss when upstream transaction conflicts during cdc reconnection

@overvenus overvenus added component/kv-client TiKV kv log client component. area/ticdc Issues or PRs related to TiCDC. labels May 25, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 25, 2022
@overvenus
Copy link
Member Author

/run-all-tests

@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 25, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 25, 2022
@sre-bot sre-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 25, 2022
@overvenus
fix complie
b9dd552 
Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus
Copy link
Member Author

/run-unit-test

@overvenus
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
@overvenus
Copy link
Member Author

/run-unit-test
/run-integration-test

@overvenus overvenus merged commit 485a10e into pingcap:release-5.0-20220525 May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy approved these changes

Assignees
No one assigned
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. component/kv-client TiKV kv log client component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@overvenus @ti-chi-bot @sdojjy @sre-bot