Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e(engine): test two running DM jobs #5581

Merged
merged 1 commit into from
May 25, 2022

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #5504

What is changed and how it works?

add test of two running jobs, so we can test about metrics later

Check List

Tests

  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

 `None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 25, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 25, 2022
@lance6716 lance6716 added the area/engine Issues or PRs related to Dataflow Engine. label May 25, 2022
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 25, 2022
@lance6716 lance6716 added the require-LGT1 Indicates that the PR requires an LGTM. label May 25, 2022
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f3181ba

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2022
@lance6716
Copy link
Contributor Author

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #5581 (f3181ba) into master (fcea4d5) will increase coverage by 0.2900%.
The diff coverage is 61.4636%.

Flag Coverage Δ
cdc 61.5427% <61.5661%> (+0.3946%) ⬆️
dm 52.0205% <61.2852%> (-0.0222%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5581        +/-   ##
================================================
+ Coverage   56.0768%   56.3669%   +0.2900%     
================================================
  Files           535        674       +139     
  Lines         70143      78468      +8325     
================================================
+ Hits          39334      44230      +4896     
- Misses        27078      30085      +3007     
- Partials       3731       4153       +422     

@ti-chi-bot ti-chi-bot merged commit 1dc5c2d into pingcap:master May 25, 2022
@lance6716 lance6716 deleted the test-two-DM-job branch October 13, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants