Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

externalresources(engine): implement GCCoordinator & GCRunner #5557

Merged
merged 7 commits into from
May 25, 2022
Merged

externalresources(engine): implement GCCoordinator & GCRunner #5557

merged 7 commits into from
May 25, 2022

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented May 24, 2022

What problem does this PR solve?

Issue Number: ref #5513

What is changed and how it works?

  • Implemented GCCoordinator.
  • Implemented GCRunner.

Check List

Tests

  • Unit test

Release note 

None

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 24, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • maxshuang

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 24, 2022
@liuzix liuzix mentioned this pull request May 24, 2022
Closed
6 tasks
@liuzix liuzix requested review from maxshuang, amyangfei, lance6716 and sleepymole and removed request for maxshuang May 24, 2022 04:50
@liuzix liuzix added the status/ptal Could you please take a look? label May 24, 2022
amyangfei
amyangfei reviewed May 24, 2022
View reviewed changes
engine/pkg/externalresource/manager/gc_coordinator.go
Comment on lines +85 to +87
if gerrors.Is(err, context.Canceled) || gerrors.Is(err, context.DeadlineExceeded) {
return errors.Trace(err)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to log/collect error here, if it is not context.Canceled or context.DeadlineExceeded

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added logging.

engine/pkg/externalresource/manager/gc_coordinator.go Outdated Show resolved Hide resolved
engine/pkg/externalresource/manager/gc_runner.go Outdated Show resolved Hide resolved
@amyangfei amyangfei added the area/engine Issues or PRs related to Dataflow Engine. label May 24, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2022
@liuzix
Copy link
Contributor Author

liuzix commented May 25, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a9bee8e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2022
@liuzix
Copy link
Contributor Author

liuzix commented May 25, 2022

/run-leak-tests

@ti-chi-bot ti-chi-bot merged commit de03021 into pingcap:master May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxshuang maxshuang maxshuang approved these changes

@amyangfei amyangfei amyangfei approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

@sleepymole sleepymole Awaiting requested review from sleepymole

Assignees
No one assigned
Labels
area/engine Issues or PRs related to Dataflow Engine. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuzix @ti-chi-bot @amyangfei @maxshuang