Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink/mq(ticdc): Add support for Confluent Cloud Kafka #5553

Merged
merged 22 commits into from
May 25, 2022
Merged

sink/mq(ticdc): Add support for Confluent Cloud Kafka #5553

merged 22 commits into from
May 25, 2022

Conversation

zhaoxinyu
Copy link
Contributor

@zhaoxinyu zhaoxinyu commented May 24, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #5512

What is changed and how it works?

  1. Support TLS/SSL encryption with a trusted ca certificate. Previously only self-signed ca certificate is supported.
  2. Loosen the strict min.insync.replica configuration parameter checking because this parameter is invisible in Confluent Cloud.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

Yes

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 24, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • hi-rustin

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. labels May 24, 2022
@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 24, 2022
@zhaoxinyu zhaoxinyu requested a review from zhangyangyu May 24, 2022 03:35
@Rustin170506 Rustin170506 changed the title mq/(ticdc): Add support for Confluent Cloud Kafka sink/mq(ticdc): Add support for Confluent Cloud Kafka May 24, 2022
@Rustin170506
Copy link
Member

CI keeps failing.

@zhaoxinyu
Copy link
Contributor Author

CI keeps failing.

Some ut needs to be modified. I am fixing it.

Rustin170506
Rustin170506 reviewed May 24, 2022
View reviewed changes
cdc/sink/mq/dispatcher/event_router.go Outdated Show resolved Hide resolved
cdc/sink/mq/producer/kafka/kafka.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 24, 2022
@zhaoxinyu
Copy link
Contributor Author

/run-all-tests

@zhaoxinyu
Copy link
Contributor Author

/run-verify

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022 •
edited
Loading

Codecov Report

Merging #5553 (f574f2b) into master (fcea4d5) will increase coverage by 0.1121%.
The diff coverage is 62.0401%.

Flag Coverage Δ
cdc 61.5181% <62.4567%> (+0.3700%) ⬆️
dm 51.9985% <61.2852%> (-0.0442%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #5553        +/-   ##
================================================
+ Coverage   56.0768%   56.1889%   +0.1121%     
================================================
  Files           535        529         -6     
  Lines         70143      69761       -382     
================================================
- Hits          39334      39198       -136     
+ Misses        27078      26833       -245     
+ Partials       3731       3730         -1

Rustin170506
Rustin170506 reviewed May 25, 2022
View reviewed changes
cdc/sink/mq/dispatcher/event_router_test.go Outdated Show resolved Hide resolved
cdc/sink/mq/producer/kafka/config.go Show resolved Hide resolved
cdc/sink/mq/producer/kafka/kafka.go Outdated Show resolved Hide resolved
pkg/logutil/log.go Outdated Show resolved Hide resolved
@zhaoxinyu
Copy link
Contributor Author

/run-verify

1 similar comment
@zhaoxinyu
Copy link
Contributor Author

/run-verify

@ti-chi-bot
Copy link
Member

@zhangyangyu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 25, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 25, 2022
@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8f62ddb

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 25, 2022
@zhangyangyu
Copy link
Member

/run-dm-integration-test

@ti-chi-bot ti-chi-bot merged commit 664b773 into pingcap:master May 25, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request May 25, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5594.

ti-chi-bot added a commit that referenced this pull request May 26, 2022
@ti-chi-bot
sink/mq(ticdc): Add support for Confluent Cloud Kafka (#5553) (#5594)
39eea6a 
close #5512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees
No one assigned
Labels
needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Confluent Cloud
6 participants
@zhaoxinyu @ti-chi-bot @Rustin170506 @codecov-commenter @zhangyangyu @3AceShowHand