-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pkg/cmd): migrate test-infra to testify for pkg/cmd #5547
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #5547 +/- ##
================================================
+ Coverage 56.0768% 56.2228% +0.1459%
================================================
Files 535 530 -5
Lines 70143 70016 -127
================================================
+ Hits 39334 39365 +31
+ Misses 27078 26917 -161
- Partials 3731 3734 +3 |
should not close #2164 in pr description? DM still has many packages to do |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1fdd35d
|
/merge |
@CharlesCheung96: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-verify |
What problem does this PR solve?
Issue Number: close #2912
What is changed and how it works?
Check List
Tests
Questions
No
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note