-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server(cdc): avoid printing help messages when cdc server exits #5524
server(cdc): avoid printing help messages when cdc server exits #5524
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-check-issue-triage-complete |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #5524 +/- ##
================================================
+ Coverage 56.0768% 56.2448% +0.1679%
================================================
Files 535 527 -8
Lines 70143 69866 -277
================================================
- Hits 39334 39296 -38
+ Misses 27078 26846 -232
+ Partials 3731 3724 -7 |
/run-integration-tests |
a9e3220
to
dcc50ce
Compare
/run-verify-test |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8a1a011
|
/run-verify-test |
In response to a cherrypick label: new pull request created: #5604. |
What problem does this PR solve?
Issue Number: close #5519
What is changed and how it works?
In
func RunE()
of thecdc server
command, if no error occurs in the validation, return nil directly in spite of errors thrown by the execution. Handle the execution errors usingcobra.CheckErr()
Tests
tests/integration_tests/cdc_server_tips
: The tests cover two scenarios: onecdc server
command with invalid arguments should print usage tips, while the other is validated and should not.cdc server
cli changefeed
Ctrl + C
and in the terminal ofcdc server
and check whether there are prompt messages printedWill it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note