Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics(ticdc): changefeed metrics add namespace label #5311

Merged
merged 24 commits into from
May 6, 2022

Conversation

sdojjy
Copy link
Member

@sdojjy sdojjy commented Apr 29, 2022

What problem does this PR solve?

Issue Number: ref #5301

What is changed and how it works?

add a new label named "namespace" to all changefeed related metrics

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 29, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 29, 2022
@sdojjy
Copy link
Member Author

sdojjy commented Apr 29, 2022

/run-integration-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 1, 2022
sdojjy added 2 commits May 5, 2022 11:03
# Conflicts:
#	cdc/kv/client.go
#	cdc/kv/client_bench_test.go
#	cdc/kv/client_test.go
#	cdc/kv/region_worker.go
#	cdc/processor/pipeline/puller.go
#	cdc/processor/processor.go
#	cdc/puller/puller_test.go
#	cdc/sink/mq/mq.go
#	cdc/sink/mysql/mysql.go
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2022
@sdojjy
Copy link
Member Author

sdojjy commented May 5, 2022

/run-all-tests

cdc/contextutil/ctx.go Outdated Show resolved Hide resolved
cdc/contextutil/ctx.go Outdated Show resolved Hide resolved
sdojjy and others added 6 commits May 5, 2022 11:54
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
@sdojjy
Copy link
Member Author

sdojjy commented May 5, 2022

/run-all-tests

@sdojjy
Copy link
Member Author

sdojjy commented May 5, 2022

/run-all-tests

…pace-label

# Conflicts:
#	cdc/contextutil/ctx.go
#	cdc/entry/mounter.go
#	cdc/kv/client.go
#	cdc/kv/region_worker.go
#	cdc/kv/token_region.go
#	cdc/model/changefeed.go
#	cdc/owner/changefeed.go
#	cdc/owner/owner.go
#	cdc/processor/pipeline/sorter.go
#	cdc/processor/processor.go
#	cdc/puller/puller.go
#	cdc/redo/writer/file.go
#	cdc/redo/writer/file_test.go
#	cdc/redo/writer/writer.go
#	cdc/sink/buffer_sink.go
#	cdc/sink/metrics/statistics.go
#	cdc/sink/mq/producer/kafka/metrics.go
#	cdc/sink/mysql/mysql.go
#	cdc/sink/sink_manager.go
#	cdc/sorter/leveldb/sorter.go
#	cdc/sorter/memory/entry_sorter.go
#	cdc/sorter/unified/heap_sorter.go
#	cdc/sorter/unified/merger.go
#	cdc/sorter/unified/unified_sorter.go
@sdojjy
Copy link
Member Author

sdojjy commented May 5, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 5, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 5, 2022
@ti-chi-bot
Copy link
Member

@nongfushanquan: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@asddongmen asddongmen added the require-LGT1 Indicates that the PR requires an LGTM. label May 6, 2022
@asddongmen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 955f038

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 6, 2022
@ti-chi-bot
Copy link
Member

@sdojjy: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 3e8e246 into pingcap:master May 6, 2022
@sdojjy sdojjy deleted the metrics-add-namespace-label branch May 6, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants