client: Fix the issue that TiKV reconnecting may make CDC stuck for a while #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyonKeminta
changed the title
MyonKeminta
added
type/bugfix
MyonKeminta
changed the title
|
/run-integration-tests |
overvenus
reviewed
May 7, 2020
cdc/kv/client_test.go
Outdated
Comment on lines
133
to
135
| // if server1 != nil { | ||
| // server1.Stop() | ||
| // } |
There was a problem hiding this comment.
Could you remove these comments?
amyangfei
reviewed
May 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #531 +/- ##
================================================
+ Coverage 26.5300% 30.7646% +4.2345%
================================================
Files 71 68 -3
Lines 7614 6683 -931
================================================
+ Hits 2020 2056 +36
+ Misses 5449 4480 -969
- Partials 145 147 +2 |
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/rebuild |
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
/rebuild |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR tries to fix the issue about reconnecting TiKV may make CDC stuck for a while, and added some debug logs for investigation.
Check List
Tests
Release note