cdc: update position and status as soon as possible #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
bobotu
force-pushed
the
refactor-worker-and-owner
branch
from
8aa6a41 to
ad00ac5
Compare
|
/run-integration-tests |
bobotu
force-pushed
the
refactor-worker-and-owner
branch
from
2f1348c to
b8eeb2e
Compare
|
/run-integration-tests |
bobotu
force-pushed
the
refactor-worker-and-owner
branch
from
b8eeb2e to
9219358
Compare
|
/run-integration-tests |
bobotu
force-pushed
the
refactor-worker-and-owner
branch
from
9219358 to
e94a27e
Compare
bobotu
changed the title
|
/run-integration-tests |
bobotu
added
the
subject/performance
|
/run-integration-tests |
bobotu
force-pushed
the
refactor-worker-and-owner
branch
from
2237237 to
40fd98f
Compare
|
/run-integration-tests |
3 similar comments
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
bobotu
force-pushed
the
refactor-worker-and-owner
branch
from
c8163cc to
0449660
Compare
|
/run-integration-tests |
bobotu
force-pushed
the
refactor-worker-and-owner
branch
from
0449660 to
1ccbf9e
Compare
|
/run-integration-tests |
bobotu
force-pushed
the
refactor-worker-and-owner
branch
from
1ccbf9e to
978b1dc
Compare
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
================================================
- Coverage 31.4302% 31.0645% -0.3657%
================================================
Files 70 70
Lines 6831 6876 +45
================================================
- Hits 2147 2136 -11
- Misses 4525 4580 +55
- Partials 159 160 +1 |
bobotu
changed the title
bobotu
force-pushed
the
refactor-worker-and-owner
branch
from
5c1150b to
eab6cd8
Compare
|
/run-integration-tests |
|
/run-kafka-tests |
…d-owner # Conflicts: # cdc/changefeed.go # cdc/processor.go
|
/run-integration-tests |
…d-owner # Conflicts: # cdc/changefeed.go # cdc/processor.go
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-all-tests |
amyangfei
reviewed
May 9, 2020
amyangfei
reviewed
May 9, 2020
added 2 commits
May 9, 2020 14:44
amyangfei
added
component/replica-model
|
/run-all-tests |
overvenus
approved these changes
May 9, 2020
overvenus
pushed a commit
to overvenus/ticdc
that referenced
this pull request
May 9, 2020
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Resolve #468.
What is changed and how it works?
For
processordo a tiny refactor to wakeup it when the resolved ts or status have changed.For
ownerit is hard to refactor the main loop, so I just add a side-channel to process an updated position as soon as possible.We can improve the efficiency of the current event model in some harder ways, such as reduce the etcd queries, do less work in the event loop, redesign the whole interaction model, etc. But these ways will change a lot of code and introduce new bugs.
For now, it is safer to do some little changes like this PR to gain some performance improvements in some scenarios.
Check List
Simple benchmark pingcap/ticdc#481 (comment)
Release note
Tests