Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependency: upgrade TiDB dependency #4310

Merged
merged 3 commits into from
Jan 13, 2022
Merged

dependency: upgrade TiDB dependency #4310

merged 3 commits into from
Jan 13, 2022

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Jan 12, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #4298

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 12, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jan 12, 2022
@GMHDBJD GMHDBJD added area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Jan 12, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jan 12, 2022

/run-all-tests

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jan 12, 2022

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 13, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jan 13, 2022

/run-kafka-test
/run-leak-test

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jan 13, 2022

/run-kafka-integration-test

Ehco1996
Ehco1996 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 13, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8020a30

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 13, 2022
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jan 13, 2022

/run-all-tests

@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Jan 13, 2022

/run-kafka-integration-test

@ti-chi-bot ti-chi-bot merged commit 0cd880f into pingcap:master Jan 13, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 13, 2022
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4315.

ti-chi-bot added a commit that referenced this pull request Jan 14, 2022
@ti-chi-bot
dependency: upgrade TiDB dependency (#4310) (#4315)
33698ed 
close #4298
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Jan 20, 2022
@GMHDBJD @zhaoxinyu
dependency: upgrade TiDB dependency (pingcap#4310)
0d59ae9 
close pingcap#4298
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM: failed to upgrade tidb and parser dependency
4 participants
@GMHDBJD @ti-chi-bot @lance6716 @Ehco1996