Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config(ticdc): No longer set open-protocol as default value for kafka sink protocol #4002

Merged
merged 13 commits into from
Dec 22, 2021
Merged

config(ticdc): No longer set open-protocol as default value for kafka sink protocol #4002

merged 13 commits into from
Dec 22, 2021

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Dec 21, 2021 •
edited
Loading

What problem does this PR solve?

close #3879

What is changed and how it works?

No longer set default values for kafka sink protocol

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported function/method change

Side effects

None

Related changes

None

Release note 

 None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 21, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • ben1009
  • sdojjy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2021
@Rustin170506
Copy link
Member Author

/cc @amyangfei @overvenus

The compatibility issue was solved in my last pr and we can stop setting the default values.

Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 21, 2021
@purelind
Copy link
Collaborator

/run-verify

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 21, 2021
@Rustin170506
Copy link
Member Author

/run-all-tests /tidb=pr/30773

@Rustin170506
Copy link
Member Author

/run-all-tests /tidb=pr/30773

@Rustin170506 Rustin170506 changed the title config(ticdc): No longer set default values for kafka sink protocol config(ticdc): No longer set default value for kafka sink protocol Dec 22, 2021
@Rustin170506
Copy link
Member Author

/uncc amyangfei overvenus

I seem to have let you guys review too much of my pr! 😆 Let me rebalance a bit.

/cc @ben1009 @sdojjy

Could you please take a look? Thanks! 💚 💙 💜 💛 ❤️

@ti-chi-bot ti-chi-bot requested review from ben1009 and removed request for amyangfei and overvenus December 22, 2021 02:50
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 22, 2021
@ben1009
Copy link
Contributor

ben1009 commented Dec 22, 2021

to my understanding, the pr aim to No longer recommend open-protocol as default value for kafka sink protocol

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 22, 2021
@Rustin170506
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5800164

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 22, 2021
@ti-chi-bot
Copy link
Member

@hi-rustin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Rustin170506 Rustin170506 changed the title config(ticdc): No longer set default value for kafka sink protocol config(ticdc): No longer set open-protocol as default value for kafka sink protocol Dec 22, 2021
@Rustin170506
Copy link
Member Author

/run-all-tests /tidb=pr/30773

@ti-chi-bot ti-chi-bot merged commit e2214aa into pingcap:master Dec 22, 2021
@Rustin170506 Rustin170506 deleted the rustin-patch-config-protocol branch December 22, 2021 05:56
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021
@Rustin170506 @zhaoxinyu
config(ticdc): No longer set open-protocol as default value for kafka…
ed10f1a 
… sink protocol (pingcap#4002)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben1009 ben1009 ben1009 approved these changes

@sdojjy sdojjy sdojjy approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add open-protocol protocol
5 participants
@Rustin170506 @ti-chi-bot @purelind @ben1009 @sdojjy