Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdc/sink: remove Initialize method from the sink interface (#3682) #3763

Merged
merged 7 commits into from
Jan 17, 2022
Merged

cdc/sink: remove Initialize method from the sink interface (#3682) #3763

merged 7 commits into from
Jan 17, 2022

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3682

What problem does this PR solve?

This PR remove the Initialized method from the sink, which is useless.

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Release note 

 `None`.

@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#3682
a6407f4 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Dec 7, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 7, 2021
Merged
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Dec 7, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2021
@overvenus overvenus added this to the v5.1.4 milestone Jan 6, 2022
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2022
@3AceShowHand
Copy link
Contributor

/run-all-tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.1@d091d4f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.1      #3763   +/-   ##
================================================
  Coverage               ?   62.0139%           
================================================
  Files                  ?        160           
  Lines                  ?      16793           
  Branches               ?          0           
================================================
  Hits                   ?      10414           
  Misses                 ?       5475           
  Partials               ?        904

@3AceShowHand
Copy link
Contributor

/run-all-tests

@3AceShowHand
Copy link
Contributor

/run-leak-tests

1 similar comment
@purelind
Copy link
Collaborator

/run-leak-tests

@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jan 13, 2022
@3AceShowHand
Copy link
Contributor

/run-all-tests

@3AceShowHand
Copy link
Contributor

/run-kafka-integration-test

@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: e3341df

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 17, 2022
@overvenus overvenus merged commit 09d4ae2 into pingcap:release-5.1 Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@3AceShowHand 3AceShowHand

Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Milestone
v5.1.4
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-chi-bot @3AceShowHand @codecov-commenter @purelind @overvenus @nongfushanquan