Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui(dm): initial implementation #3449

Merged
merged 21 commits into from
Dec 13, 2021
Merged

webui(dm): initial implementation #3449

merged 21 commits into from
Dec 13, 2021

Conversation

zoubingwu
Copy link
Member

@zoubingwu zoubingwu commented Nov 14, 2021

What problem does this PR solve?

Added web ui for dm

  • create source
  • list all source

image

image

Release note

Add a web user interface for dm

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 14, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 14, 2021
@CLAassistant
Copy link

CLAassistant commented Nov 14, 2021

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 14, 2021
@Ehco1996 Ehco1996 added the area/dm Issues or PRs related to DM. label Nov 18, 2021
@zoubingwu zoubingwu marked this pull request as ready for review November 19, 2021 08:15
@zoubingwu zoubingwu changed the title wip: dm web ui dm/ui: initial implementation Nov 19, 2021
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-none Denotes a PR that doesn't merit a release note. labels Nov 19, 2021
@Ehco1996 Ehco1996 changed the title dm/ui: initial implementation webui(dm): initial implementation Nov 22, 2021
dm/ui/.eslintrc.js Show resolved Hide resolved
dm/ui/.gitignore Outdated Show resolved Hide resolved
dm/ui/.husky/pre-commit Show resolved Hide resolved
dm/ui/src/App.tsx Outdated Show resolved Hide resolved
@Ehco1996 Ehco1996 mentioned this pull request Nov 23, 2021
14 tasks
@zoubingwu zoubingwu requested a review from Ehco1996 November 29, 2021 08:53
dm/ui/.husky/pre-commit Show resolved Hide resolved
dm/ui/src/models/source.ts Outdated Show resolved Hide resolved
dm/README.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #3449 (7fe6ea6) into master (eed6f9b) will decrease coverage by 0.3604%.
The diff coverage is 59.8130%.

Flag Coverage Δ
cdc 58.0087% <76.1479%> (-0.4285%) ⬇️
dm 56.0807% <44.2143%> (-0.2945%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #3449        +/-   ##
================================================
- Coverage   57.3452%   56.9847%   -0.3605%     
================================================
  Files           460        472        +12     
  Lines         54927      56122      +1195     
================================================
+ Hits          31498      31981       +483     
- Misses        20180      20882       +702     
- Partials       3249       3259        +10     

@zoubingwu zoubingwu requested a review from Ehco1996 December 6, 2021 08:13
@Ehco1996
Copy link
Contributor

Ehco1996 commented Dec 7, 2021

Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 7, 2021
@baurine
Copy link
Contributor

baurine commented Dec 7, 2021

lgtm

@Ehco1996
Copy link
Contributor

Ehco1996 commented Dec 8, 2021

could you please take another look for this pr ? thanks 🧡🧡🧡

/cc @lance6716 @lichunzhu @glorv

@zoubingwu zoubingwu requested review from baurine and glorv December 10, 2021 04:41
@zoubingwu
Copy link
Member Author

fixed mentioned issues, need one more approval

cc @lance6716 @lichunzhu @baurine @glorv

@ti-chi-bot
Copy link
Member

@baurine: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

Makefile Outdated Show resolved Hide resolved
dm/dm/master/server.go Show resolved Hide resolved
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

@lance6716: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 13, 2021
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: caa5c55

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 13, 2021
@Ehco1996
Copy link
Contributor

/run-integration-test

@purelind
Copy link
Collaborator

/run-integration-test

@ti-chi-bot
Copy link
Member

@zoubingwu: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 2e7ac9a into pingcap:master Dec 13, 2021
@zoubingwu zoubingwu deleted the dev branch December 14, 2021 04:48
zhaoxinyu pushed a commit to zhaoxinyu/ticdc that referenced this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants