Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sink: fix kafka max message size inaccurate issue. (#3002) #3046

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3002

What problem does this PR solve?

try to close #2962

What is changed and how it works?

  • When calculating the length of encoded MQMessage, also consider the maximumRecordOverhead, which was introduced by the sarama client.
  • Ignoring max-message-size at the producer level, default to 512m. max-message-size only works for the encoder.
  • Change log level to Debug when AppendRowChangedEvent in json encoder.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Code changes
Side effects

Related changes

Release note

fix kafka sink can not send message due to constraint by `max-message-size` option.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/sink Sink component. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Oct 14, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 14, 2021
@amyangfei amyangfei added this to the v4.0.16 milestone Oct 14, 2021
@3AceShowHand
Copy link
Contributor

/run-all-tests

@3AceShowHand
Copy link
Contributor

/run-kafka-tests
/run-unit-tests

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: b88d5d8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 15, 2021
@ti-chi-bot ti-chi-bot merged commit 5cb4dc7 into pingcap:release-4.0 Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/sink Sink component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants