Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add ddl execution duration metrics (#2671) #2684

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2671

What problem does this PR solve?

try to close #2595, also fix #2669

What is changed and how it works?

  • add histogram as metric for DDL execution duration.
  • add grafana panel to monitor it
    • MySQL sink ddl execution duration -> Heatmap
    • MySQL sink ddl execution duration percentile -> graph
  • update some other old grafana panel.
    • Processor Memory Consumption Per Changefeed. table -> graph
    • changefeed checkpoint lag -> set min to 0 for yAxis

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

Release note

Please add a release note.
If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. component/metrics-logging Metrics and logging component. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Aug 31, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 1, 2021
@amyangfei amyangfei added this to the v5.2.1 milestone Sep 1, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 11f7d47

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
@3AceShowHand
Copy link
Contributor

/run-kafka-tests

@3AceShowHand
Copy link
Contributor

/run-unit-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

2 similar comments
@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests /pd=release-5.2 /tidb=release-5.2 /tikv=release-5.2

3 similar comments
@amyangfei
Copy link
Contributor

/run-kafka-tests /pd=release-5.2 /tidb=release-5.2 /tikv=release-5.2

@amyangfei
Copy link
Contributor

/run-kafka-tests /pd=release-5.2 /tidb=release-5.2 /tikv=release-5.2

@amyangfei
Copy link
Contributor

/run-kafka-tests /pd=release-5.2 /tidb=release-5.2 /tikv=release-5.2

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@amyangfei
Copy link
Contributor

/run-integration-tests /pd=release-5.2 /tidb=release-5.2 /tikv=release-5.2 /tiflash=release-5.2

@amyangfei
Copy link
Contributor

/run-kafka-tests /pd=release-5.2 /tidb=release-5.2 /tikv=release-5.2 /tiflash=release-5.2

@amyangfei
Copy link
Contributor

/run-integration-tests /pd=release-5.2 /tidb=release-5.2 /tikv=release-5.2 /tiflash=release-5.2

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@a355c22). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.2      #2684   +/-   ##
================================================
  Coverage               ?   55.8921%           
================================================
  Files                  ?        169           
  Lines                  ?      20697           
  Branches               ?          0           
================================================
  Hits                   ?      11568           
  Misses                 ?       8020           
  Partials               ?       1109           

@ti-chi-bot ti-chi-bot merged commit 6b6c060 into pingcap:release-5.2 Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants